[SYCL][E2E] Fix CUDA/HIP options on Windows #17985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
requested review from
maarquitos14,
uditagarwal97,
ayylol and
aelovikov-intel
|
@sarnex does this also address this issue? |
|
Partially, we also need this change though. Once that's merged I'll re-enable those tests. |
sarnex
pushed a commit
that referenced
this pull request
May 27, 2025
Currently when we check `REQUIRES`/`UNSUPPORTED` statements in `build-only` mode we throw an error if any feature that is not in `build_specific_features` evaluates to true. Since this is error will only trigger when a test queries for one of these features, it can be easy to miss adding new build-specific features to this list (see #17985, and #17363). This pr changes this check to be done for all features when in `build-only`, not just those queried by a test. If any available feature does not appear in `build_specific_features` then an error is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set
cuda-path/hip-pathon Windows as the autodetection isn't implemented upstream, it seems only implemented for Linux.Also fix a double assign and a missed update in
E2EExprThis was tested with some other pending changes here and here.