[SYCL][Driver] Mark DeviceLib option as deprecated #18581
+53
−531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <[email protected]>
mdtoguchi
reviewed
May 21, 2025
| @@ -7036,19 +7036,22 @@ def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">, | |||
| def fno_sycl_dead_args_optimization : Flag<["-"], "fno-sycl-dead-args-optimization">, | |||
| HelpText<"Disables elimination of DPC++ dead kernel arguments">; | |||
| def fsycl_device_lib_EQ : CommaJoined<["-"], "fsycl-device-lib=">, | |||
| Flags<[NoXarchOption]>, | |||
| Flags<[Deprecated]>, | |||
There was a problem hiding this comment.
@jinge90, there is also an associated test clang/test/Driver/sycl-deprecated.cpp can that test be updated?
There was a problem hiding this comment.
Hi, @mdtoguchi
The sycl-deprecated.cpp is updated.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decide to remove sycl device library jit link path, the 1st step is to mark all related driver option as 'deprecated' and cleared all tests using these options.