-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Driver] Mark DeviceLib option as deprecated #18581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
Signed-off-by: jinge90 <[email protected]>
@@ -7036,19 +7036,22 @@ def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">, | |||
def fno_sycl_dead_args_optimization : Flag<["-"], "fno-sycl-dead-args-optimization">, | |||
HelpText<"Disables elimination of DPC++ dead kernel arguments">; | |||
def fsycl_device_lib_EQ : CommaJoined<["-"], "fsycl-device-lib=">, | |||
Flags<[NoXarchOption]>, | |||
Flags<[Deprecated]>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinge90, there is also an associated test clang/test/Driver/sycl-deprecated.cpp
can that test be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mdtoguchi
The sycl-deprecated.cpp is updated.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
We decide to remove sycl device library jit link path, the 1st step is to mark all related driver option as 'deprecated' and cleared all tests using these options.