Skip to content

[SYCL][Driver] Mark DeviceLib option as deprecated #18581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented May 21, 2025

We decide to remove sycl device library jit link path, the 1st step is to mark all related driver option as 'deprecated'.

@jinge90 jinge90 requested a review from a team as a code owner May 21, 2025 08:08
@jinge90 jinge90 requested a review from mdtoguchi May 21, 2025 08:09
@@ -7036,19 +7036,22 @@ def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">,
def fno_sycl_dead_args_optimization : Flag<["-"], "fno-sycl-dead-args-optimization">,
HelpText<"Disables elimination of DPC++ dead kernel arguments">;
def fsycl_device_lib_EQ : CommaJoined<["-"], "fsycl-device-lib=">,
Flags<[NoXarchOption]>,
Flags<[Deprecated]>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinge90, there is also an associated test clang/test/Driver/sycl-deprecated.cpp can that test be updated?

@jinge90 jinge90 requested a review from a team as a code owner May 30, 2025 06:05
@jinge90 jinge90 requested a review from sergey-semenov May 30, 2025 06:05
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 06:05 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 07:35 — with GitHub Actions Inactive
Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 08:12 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 08:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants