[NFC][SYCL] Speed up device_impl::CallOnceCache on fast path for libstdc++
#18597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bstdc++ libstdc++ implementation of `std::call_once` isn't as performant as it could be due to ABI compatibility reasons (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66146#c53). We can optimize fast path but paying some price for less important memory usage/slow path performance. Bassed on generated code (https://godbolt.org/z/1YaW5xozY) I wouldn't be surprised if the same would help on Windows, but I'd prefer to investigate/implement in a separate PR if necessary.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@Alexandr-Konovalov could you review this too, please? I think it's similar enough to the check-lock-check PR. |
sergey-semenov
approved these changes
May 22, 2025
Sure, I read the fix and it looks good to me. |
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libstdc++ implementation of
std::call_onceisn't as performant as it could be due to ABI compatibility reasons (seehttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=66146#c53).
We can optimize fast path but paying some price for less important memory usage/slow path performance.
Based on generated code (https://godbolt.org/z/1YaW5xozY) I wouldn't be surprised if the same would help on Windows, but I'd prefer to investigate/implement in a separate PR if necessary.