[UR] Support conditional symbols in linker scripts #18629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2025
kbenzie
force-pushed
the
benie/ur-linker-script-conditional-symbols
branch
from
c81041b to
466c42d
Compare
RossBrunton
reviewed
May 23, 2025
RossBrunton
reviewed
May 23, 2025
The `get_loader_functions()` template helper now returns `list[dict]` instead of `list[str]`, this enables passing additional information into the loader script templates.
In order to pre-process files which don't support conditional inclusion of line blocks, such as linker scripts, we can use this script to remove lines which should not be included unless specified.
Actually use the `strip-guarded-lines.py` script when using `configure_file()` on linker scripts.
kbenzie
force-pushed
the
benie/ur-linker-script-conditional-symbols
branch
from
466c42d to
0ca3e85
Compare
RossBrunton
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined the following changes enable adding guards around sections in linker script files which do not support conditional inclusion in their syntax. This is done by pre-processing the linker scripts as part of build configuration.
helper.pyand add typing hintsget_loader_functions()template helper now returnslist[dict]instead oflist[str], this enables passing additional information into the loader script templatesstrip-guarded-lines.pystrip-guarded-lines.pyscript when usingconfigure_file()on linker scripts