[SYCL][E2E] Add local_accessor and accessor tests for sycl_ext_oneapi_free_function_kernels extension
#18672
Conversation
…_free_function_kernels
…_free_function_kernels
dyniols
changed the title
sycl_ext_oneapi_free_function_kernels extension local_accessor and accessor e2e tests for sycl_ext_oneapi_free_function_kernels extension
|
Closing PR and enabling it back again to rerun CI |
dyniols
changed the title
local_accessor and accessor e2e tests for sycl_ext_oneapi_free_function_kernels extension local_accessor and accessor tests for sycl_ext_oneapi_free_function_kernels extension
|
It would we much more effective if someone already familiar with the test plan would be reviewing this. |
| #include "helpers.hpp" | ||
|
|
||
| SYCL_EXT_ONEAPI_FUNCTION_PROPERTY((syclexp::single_task_kernel)) | ||
| void globalScopeSingleFreeFunc(sycl::accessor<int, 1> Accessor, |
There was a problem hiding this comment.
can we also test an accessor with Dim 2 and 3 ? Because of the way they are lowered we've had problems before that were similarly undetected because we were only testing Dim==1 .
There was a problem hiding this comment.
Sure, I will add checks to the test for accessor with Dim 2 and 3
There was a problem hiding this comment.
I may be wrong, but it seems to me like Chris wanted approximately the same test case but with different dimensionality. Could we make it a templated function and adapt the test cases to run for each dimension?
There was a problem hiding this comment.
Sure, it can be done.
…_free_function_kernels
sycl/test-e2e/FreeFunctionKernels/accessor_as_kernel_parameter.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/FreeFunctionKernels/accessor_as_kernel_parameter.cpp
Outdated
Show resolved
Hide resolved
….cpp Co-authored-by: Steffen Larsen <[email protected]>
…//github.com/DYNIO-INTEL/llvm into add_more_e2e_tests_for_free_function_kernels
….cpp Co-authored-by: Steffen Larsen <[email protected]>
| sycl::nd_item<2> NdItem = syclext::this_work_item::get_nd_item<2>(); | ||
| Accessor[NdItem.get_group_linear_id()][NdItem.get_local_linear_id()] = Value; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we also add a test that involves multiple accessor parameters?
This PR adds new e2e tests for free function kernels extension based on test plan https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/FreeFunctionKernels/test-plan.md