[UR] Remove global DDI table entries #18704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
reviewed
May 28, 2025
unified-runtime/source/adapters/offload/ur_interface_loader.cpp
Outdated
Show resolved
Hide resolved
kbenzie
force-pushed
the
benie/ur-spec-remove-globals
branch
from
5fe550b to
77182f3
Compare
npmiller
approved these changes
May 29, 2025
hvdijk
approved these changes
May 29, 2025
jchlanda
approved these changes
May 29, 2025
RossBrunton
approved these changes
May 29, 2025
All global DDI table entries were in fact adapter entries. This patch moves these entries into the adapter class thus removing the `urGetGlobalProcAddrTable()` entry.
kbenzie
force-pushed
the
benie/ur-spec-remove-globals
branch
from
77182f3 to
e6a7842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All global DDI table entries were in fact adapter entries. This patch moves these entries into the adapter class thus removing the
urGetGlobalProcAddrTable()entry.