-
Notifications
You must be signed in to change notification settings - Fork 769
[CI] Remove dependency on devops/scripts/benchmarks/** from IGC dev containers workflow #18732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's wrong reason. Are you sure there is nothing in devops/scripts
that should trigger this task?
@aelovikov-intel That's my bad, I'm using exclusions now: I glossed over the docs and took you couldn't use paths and paths-ignore at the same time meant you couldn't exclude while including at the same time -- fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you going to test/verify this?
If I make 2 dummy PRs that both removes
Will that be sufficient? We are essentially testing that github workflows syntax features behave as they describe in documentation here, I'd imagine they do something like this behind the scenes. |
Please create two test PRs, one where testing is expected (make sure the "negative" path is modified in that PR as well) to happen and one where it's not. |
The dependency on devops/scripts/** causes any changes in devops/scripts/benchmarks/** (unrelated to IGC dev containers) to fail as well: exclude this path.