Skip to content

[CI] Remove dependency on devops/scripts/benchmarks/** from IGC dev containers workflow #18732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented May 29, 2025

The dependency on devops/scripts/** causes any changes in devops/scripts/benchmarks/** (unrelated to IGC dev containers) to fail as well: exclude this path.

@ianayl ianayl requested a review from a team as a code owner May 29, 2025 15:54
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's wrong reason. Are you sure there is nothing in devops/scripts that should trigger this task?

@ianayl ianayl changed the title [CI] Remove dependency on devops/scripts/** from IGC dev containers workflow [CI] Remove dependency on devops/scripts/benchmarks/** from IGC dev containers workflow May 29, 2025
@ianayl
Copy link
Contributor Author

ianayl commented May 29, 2025

@aelovikov-intel That's my bad, I'm using exclusions now: I glossed over the docs and took you couldn't use paths and paths-ignore at the same time meant you couldn't exclude while including at the same time -- fixed now

@ianayl ianayl requested a review from aelovikov-intel May 29, 2025 16:04
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you going to test/verify this?

@ianayl ianayl temporarily deployed to WindowsCILock May 29, 2025 16:12 — with GitHub Actions Inactive
@ianayl
Copy link
Contributor Author

ianayl commented May 29, 2025

If I make 2 dummy PRs that both removes path: '.github/workflows/sycl-containers-igc-dev.yaml', and:

  • one make a dummy change in devops/benchmarking, where we expect the workflow to not trigger
  • one makes a dummy change in devops/dependencies-igc-dev.json, where we expect the workflow to trigger

Will that be sufficient? We are essentially testing that github workflows syntax features behave as they describe in documentation here, I'd imagine they do something like this behind the scenes.

@aelovikov-intel aelovikov-intel merged commit f27a817 into sycl May 29, 2025
20 of 25 checks passed
@aelovikov-intel
Copy link
Contributor

Please create two test PRs, one where testing is expected (make sure the "negative" path is modified in that PR as well) to happen and one where it's not.

@ianayl
Copy link
Contributor Author

ianayl commented May 29, 2025

Negative path (should not trigger IGC dev container workflow): #18736
Positive path (should trigger IGC dev container workflow): #18737

Changes seem to check out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants