Continue Axios Migration #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #143
Axios is not a drop-in replacement for Popsicle. Here are a few of the API differences:
data
instead ofbody
.Axios.get()
will override the themethod
option.transport
option.res.data
.JSON.stringify()
because ofres.request
.Breaking Change
Given the
transport
issue, this PR does introduce a breaking change. Users that receive a PDF will have to change their code from this:To this:
In my opinion, switching to Axios is still worth it.
Testing
The only things I use this package for are creating redirects and creating tokens, so those are the only things I've tested. Other users should test out the rest of the package before this PR is merged.