Skip to content

remove enum34 to avoid issue with python 3.5+ #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove enum34 to avoid issue with python 3.5+ #4

wants to merge 1 commit into from

Conversation

gionniboy
Copy link

We experienced an issue in a python 3.6 environment during the install of dependencies due to enum34.

AttributeError: module 'enum' has no attribute 'IntFlag'

Generally, it's considered good practice to utilize enum34 with Python versions 3.4 (or earlier), as stated by the packages description[1] (and a number of additional GitHub issues[2][3]):

'Python 3.4 Enum backported to 3.3, 3.2, 3.1, 2.7, 2.6, 2.5, and 2.4'

If you require the functionality of enum34, I'd recommend utilizing aenum[4], or another package which would fit your purposes.

References:
[1] https://pypi.org/project/enum34/
[2] PyCQA/flake8-import-order#148
[3] snipsco/snips-nlu#649
[4] https://pypi.org/project/aenum/

@coveralls
Copy link

coveralls commented Jan 25, 2019

Pull Request Test Coverage Report for Build 35

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.5%

Totals Coverage Status
Change from base Build 33: 0.0%
Covered Lines: 183
Relevant Lines: 200

💛 - Coveralls

@nbhambhani
Copy link
Contributor

Thanks @gionniboy for reporting this. I have replaced enum34 library with enum-compat which installs enum34 for Python < 3.4. I'll release the new package soon.

@nbhambhani nbhambhani closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants