Skip to content

feat: expose appStartPath on cap config server configuration #8019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

benmccarty91
Copy link
Contributor

@benmccarty91 benmccarty91 commented May 28, 2025

Fixes 7972.
closes 3912

These changes introduce a new capacitor.config flag, appStartPath.

On iOS and Android, the logic already existed, but there was no way to configure this value. This PR simply exposes that configuration.

@benmccarty91 benmccarty91 marked this pull request as ready for review May 28, 2025 21:00
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.
Also this should be a feat, not a fix since it adds a new configuration option.

@benmccarty91 benmccarty91 changed the title fix: sveltekit hash routing broken on iOS feat: sveltekit hash routing iOS compatibility May 29, 2025
@benmccarty91 benmccarty91 requested a review from jcesarmobile May 29, 2025 18:35
@benmccarty91 benmccarty91 force-pushed the fix/RDMR-650/ios-hash-routing branch from f6ca9d5 to c41996d Compare June 2, 2025 14:14
@benmccarty91 benmccarty91 changed the title feat: sveltekit hash routing iOS compatibility feat: expose appStartPath on cap config server configuration Jun 2, 2025
@benmccarty91 benmccarty91 requested a review from jcesarmobile June 3, 2025 13:50
@markemer markemer merged commit a274fef into main Jun 3, 2025
6 checks passed
@markemer markemer deleted the fix/RDMR-650/ios-hash-routing branch June 3, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants