Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Repair DAG diagram that was broken in #125 #126

Closed

Conversation

Mr0grog
Copy link

@Mr0grog Mr0grog commented Sep 2, 2022

It looks like an automated process destroyed one of the DAG diagrams in the balanced builder in #125. Specifically, it seems like gofmt didn’t really like this comment and reformatted it.

This restores the diagram and makes some slight changes so that gofmt won't break it again.

web3-bot and others added 2 commits August 26, 2022 10:34
This makes some slight changes so that gofmt won't break it again (which seems to have been the source of the original breakage).
@welcome
Copy link

welcome bot commented Sep 2, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

// +=========+ +=========+ +=========+ +=========+ +=========+
// | Chunk 1 | | Chunk 2 | | Chunk 3 | | Chunk 4 | | Chunk 5 |
// +=========+ +=========+ +=========+ +=========+ +=========+
// Example balanced DAG:
Copy link
Author

@Mr0grog Mr0grog Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A line of text (that’s not indented with the list above it) appears to be required here. Otherwise, gofmt sees the diagram as part of the numbered list above, and indents and reformats it.

@Mr0grog
Copy link
Author

Mr0grog commented Nov 22, 2022

Ping! This has been sitting for a few months. Just checking in here on whether I need to make any changes for this — it should only touch comments. (I think some automated tooling has rebased and added another commit; let me know if I should manually fix/rebase so it's a cleaner patch.)

@Jorropo
Copy link
Contributor

Jorropo commented Jun 26, 2023

This repository is no longer maintained and has been copied over to Boxo.
Please reopen this PR inside boxo/unixfs I'll merge it there thx. 🙂

You can learn more in the FAQs for the Boxo repo copying/consolidation effort.

@Jorropo Jorropo closed this Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants