Check explicitly for DAGLink instance. #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ module.exports = class DAGNode { | |||
| // ensure links are instances of DAGLink | |||
| if (links) { | |||
| links.forEach((l) => { | |||
| if (l.name && typeof l.toJSON === 'function') { | |||
| if (l instanceof DAGLink) { | |||
There was a problem hiding this comment.
No! you can not do that (sadly). We explicitly removed this because this will fail if there are two different versions of this module are used. And will give you many false negatives in that case
There was a problem hiding this comment.
Yeah, I just ran into this the other day. Let's check constructor instead -- I think that will be more reliable. Thanks for catching this.
|
ping @vijayee |
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes previously failing test, occurring when passing in a
DAGLinkinstance with no name.