Skip to content

chore: bump interface-blockstore from 1.0.2 to 2.0.2 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2021

Bumps interface-blockstore from 1.0.2 to 2.0.2.

Release notes

Sourced from interface-blockstore's releases.

[email protected]

2.0.2 (2021-09-08)

Note: Version bump only for package interface-blockstore

[email protected]

2.0.2 (2021-09-08)

Note: Version bump only for package interface-blockstore-tests

[email protected]

2.0.1 (2021-09-08)

Note: Version bump only for package interface-blockstore

[email protected]

2.0.1 (2021-09-08)

Note: Version bump only for package interface-blockstore-tests

[email protected]

2.0.0 (2021-09-08)

chore

BREAKING CHANGES

  • deep requires/imports are no longer possible, moves adapters/in-memory impls etc to core packages

[email protected]

2.0.0 (2021-09-08)

chore

BREAKING CHANGES

  • deep requires/imports are no longer possible, moves adapters/in-memory impls etc to core packages

[email protected]

1.0.3 (2021-09-02)

Note: Version bump only for package interface-blockstore-tests

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 9, 2021
Bumps [interface-blockstore](https://github.com/ipfs/js-ipfs-interfaces) from 1.0.2 to 2.0.2.
- [Release notes](https://github.com/ipfs/js-ipfs-interfaces/releases)
- [Commits](https://github.com/ipfs/js-ipfs-interfaces/compare/[email protected]@2.0.2)

---
updated-dependencies:
- dependency-name: interface-blockstore
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/interface-blockstore-2.0.2 branch from fbfbdb7 to 25f02ee Compare September 14, 2021 06:39
@yusefnapora
Copy link
Contributor

yusefnapora commented Jan 24, 2022

@vasco-santos is there any reason not to pull this in? I think the old dependency is causing issues with metaplex. I'm suddenly getting a bunch of type errors like this:

$ tsc -p ./src
../../node_modules/blockstore-core/types/src/base.d.ts(33,5): error TS2416: Property 'put' in type 'BaseBlockstore' is not assignable to the same property in base type 'Blockstore'.
  Type '(key: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/blockstore-core/node_modules/multiformats/types/src/cid").CID, val: Uint8Array, options?: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/blockstore-core/node_modules/interface-blockstore/dist/src/index").Options) => Prom...' is not assignable to type '(key: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/multiformats/types/cid").CID, val: Uint8Array, options?: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/interface-store/dist/src/index").Options) => Promise<...>'.
    Types of parameters 'key' and 'key' are incompatible.
      Type 'import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/multiformats/types/cid").CID' is not assignable to type 'import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/blockstore-core/node_modules/multiformats/types/src/cid").CID'.
        Types have separate declarations of a private property 'asCID'.
../../node_modules/blockstore-core/types/src/base.d.ts(39,5): error TS2416: Property 'get' in type 'BaseBlockstore' is not assignable to the same property in base type 'Blockstore'.
  Type '(key: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/blockstore-core/node_modules/multiformats/types/src/cid").CID, options?: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/blockstore-core/node_modules/interface-blockstore/dist/src/index").Options) => Promise<...>' is not assignable to type '(key: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/multiformats/types/cid").CID, options?: import("/Users/yusef/work/projects/metaplex/metaplex/js/node_modules/interface-store/dist/src/index").Options) => Promise<...>'.

It looks blockstore-core depends on interface-blockstore 2.0.2, but I think because this package still depends on 1.0.2 it's causing issues with metaplex.

That's the best I can guess from looking at yarn list output anyway :)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 26, 2022

A newer version of interface-blockstore exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@achingbrain
Copy link
Member

Superseded by #220

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 27, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/interface-blockstore-2.0.2 branch May 27, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants