Skip to content

Sets enable_stabilization to false by default. #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AntoineRichard
Copy link
Contributor

@AntoineRichard AntoineRichard commented Jun 5, 2025

Description

Changes the default setting for the enable stabilization flag from True to False.

Fixes #2319

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Before After
net_contact_forces_1kz net_contact_forces_after
force_matrices_1khz force_matrices_after

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@AntoineRichard AntoineRichard marked this pull request as ready for review June 6, 2025 09:34
@kellyguo11 kellyguo11 changed the title Setting enable_stabilization to false by default. Sets enable_stabilization to false by default. Jun 9, 2025
@kellyguo11
Copy link
Contributor

test_rigid_object.py seems to be failing, could you check if it's passing locally?

.. note::
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we throw a warning about this finding from the code? This way users know that if they see some issues in forces, they have a heads up?

.. note::
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz).
We recommend setting this flag to true only when the simulation step size is large (i.e., less than 30 Hz or more than 0.0333 seconds).

.. note::
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz).
Enabling this flag can lead to incorrect forces being read from the contact sensor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a warning. Also a bit confusing: are forces just computed incorrectly or they are reported wrong?

Suggested change
Enabling this flag can lead to incorrect forces being read from the contact sensor.
.. warn::
Enabling this flag may lead to incorrect contact forces report from the contact sensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants