-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Sets enable_stabilization to false by default. #2628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
test_rigid_object.py seems to be failing, could you check if it's passing locally? |
.. note:: | ||
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we throw a warning about this finding from the code? This way users know that if they see some issues in forces, they have a heads up?
.. note:: | ||
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz). | |
We recommend setting this flag to true only when the simulation step size is large (i.e., less than 30 Hz or more than 0.0333 seconds). |
.. note:: | ||
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz). | ||
Enabling this flag can lead to incorrect forces being read from the contact sensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a warning. Also a bit confusing: are forces just computed incorrectly or they are reported wrong?
Enabling this flag can lead to incorrect forces being read from the contact sensor. | |
.. warn:: | |
Enabling this flag may lead to incorrect contact forces report from the contact sensor. |
Description
Changes the default setting for the enable stabilization flag from True to False.
Fixes #2319
Type of change
Screenshots
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there