Skip to content

update to netbeans 16 to fix build #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Dec 17, 2022

No description provided.

@neph1 neph1 merged commit f751999 into jMonkeyEngine:master Dec 17, 2022
@tonihele
Copy link
Contributor

NB 16 is a bit broken. So better not release with it. Some Gradle stuff i.e. broken and they are working on a hotfix. Did you also check that does the installer need a upgrade? Or maybe doesn't matter if we are not going to release with 16.

@tonihele
Copy link
Contributor

@neph1
Copy link
Contributor Author

neph1 commented Dec 17, 2022

Still safer to stay with nb15? I don't know. You seem to know more so you take the decision 😁

@tonihele
Copy link
Contributor

tonihele commented Dec 17, 2022

https://github.com/jMonkeyEngine/sdk/blob/master/build.gradle#L559 we have this @MeFisto94 magic in-place. I'm in favour of always taking up-to-date NB. Given there is no broken peaces (that we know of). And now if they already released the patch, we will also release with that. So that is ok.

The NB upgrade script was crafted mainly for NB LTS releases which made much sense to stick with. But there are no LTS releases anymore. Still situations like this, it should still deliver :)

@tonihele
Copy link
Contributor

The process of upgrading NB is the following:

We should really document this. Although.... again, with Maven, obsolete :)

@neph1
Copy link
Contributor Author

neph1 commented Dec 17, 2022

So something like this: #442
(harness hadn't changed)

@neph1 neph1 deleted the update_to_netbeans_16 branch May 6, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants