Use ParseConfigError in pgx.ParseConfig and pgxpool.ParseConfig
#2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move pgconn.NewParseConfigError function to errors.go from export_test.go for creatin pgconn.ParseConfigError inside the pgx and pgxpool packages.
Nomlsbad
changed the title
ParseConfigError in pgx.ParseConfig and pgxpool.ParseConfig
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ParseConfigfunctions in thepgxandpgxpoolpackages currently do not use thepgconn.ParseConfigErrortype for errors they return.This PR updates them to correctly use
pgconn.ParseConfigError.