Fix: a test relied on faulty behavior #5028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assert.throws` did not test for the error message so far. This changes it to actually test for the error message.
|
Thanks! |
Closed
GeoffreyBooth
added a commit
to GeoffreyBooth/coffeescript
that referenced
this pull request
Apr 30, 2018
GeoffreyBooth
added a commit
that referenced
this pull request
May 1, 2018
#5047) * Explicitly turn off minify mangling, because it was previously implicitly disabled by the existence of the `eval` call we’re about to remove * Update babel-core * Run browser-compiled scripts using window.eval rather than just eval, to use a clean scope (many times faster) * Update output * Fix browser-based test broken by #5028 * Update output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in CITGM while improving assert.throws in Node.js. See nodejs/node#19867 for more information.
The current tests never checked for the error message and instead would just ignore that argument. It would only be used in case no error is thrown and that is not the intention in this case.
This makes sure the error message is actually tested for.