Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GeoffreyBooth a couple Prettier-related changes to try and make generation of
::
constructs safer:.
,?.
and::
areLINE_CONTINUER
s but?::
is not. So add it so that line-breaking before any kind ofAccessor
(other than a "computed" one, ie anIndex
eg['a']
) should be safe::
(ie just referencing the.prototype
object) as well as::
followed by aProperty
.?::
has no standalone version in the grammar. So add it, since currently in Prettier I'm auto-transforming any.prototype
access into::
, so if the original source were ega?.prototype
it'd generatea?::
, which currently won't compile. If it ends up making sense to only generate::
when explicit::
was in the original source, that should just be a question of eg adding aprototypeShorthand: yes
flag to theAccess
in the grammar, but there's no harm in allowing standalone?::
regardless