[pull] main from modelcontextprotocol:main #80
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| @@ -25,7 +25,7 @@ def get_user_profile(user_id: str) -> str: | |||
| # The handler returns a ServerResult with a ListResourceTemplatesResult inside | |||
| result = await mcp._mcp_server.request_handlers[types.ListResourceTemplatesRequest]( | |||
| types.ListResourceTemplatesRequest( | |||
| method="resources/templates/list", params=None, cursor=None | |||
| method="resources/templates/list", params=None | |||
There was a problem hiding this comment.
The cursor parameter has been removed from the ListResourceTemplatesRequest constructor. If this is due to an API change, it might be worth adding a comment explaining why this parameter is no longer needed, especially since this is in a test for issue modelcontextprotocol#129.
| class ListResourcesRequest(PaginatedRequest[Literal["resources/list"]]): | ||
| """Sent from the client to request a list of resources the server has.""" | ||
|
|
||
| method: Literal["resources/list"] | ||
| params: RequestParams | None = None | ||
|
|
There was a problem hiding this comment.
The ListResourcesRequest class no longer defines its own params field, which is good since it inherits this from PaginatedRequest. However, there's an inconsistency: the method field is still explicitly defined while other similar classes (like ListResourceTemplatesRequest) also have their method field defined explicitly. For consistency, either all paginated request classes should define both fields or inherit both.
| params=types.PaginatedRequestParams(cursor=cursor) | ||
| if cursor is not None | ||
| else None, |
There was a problem hiding this comment.
The conditional formatting for the params parameter could be simplified for better readability. Consider using a one-liner or a separate variable assignment before the method call.
| params=types.PaginatedRequestParams(cursor=cursor) | |
| if cursor is not None | |
| else None, | |
| params=types.PaginatedRequestParams(cursor=cursor) if cursor is not None else None, |
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )