Skip to content

🎨 Proper support for static methods that were in v1.x #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2021

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented Aug 14, 2021

Something was not quite right with the v1 support regarding:

  • CharsetNormalizerMatches.from_bytes
  • CharsetNormalizerMatches.from_fp
  • CharsetNormalizerMatches.from_path
  • CharsetNormalizerMatches.normalize

This PR provides a better/cleaner implt.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #82 (851594f) into master (14c74b4) will decrease coverage by 0.39%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   84.68%   84.28%   -0.40%     
==========================================
  Files          11       11              
  Lines        1149     1171      +22     
==========================================
+ Hits          973      987      +14     
- Misses        176      184       +8     
Impacted Files Coverage Δ
charset_normalizer/models.py 87.04% <ø> (-0.07%) ⬇️
charset_normalizer/legacy.py 75.00% <69.23%> (-11.67%) ⬇️
charset_normalizer/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c74b4...851594f. Read the comment docs.

@Ousret Ousret merged commit 516a1af into master Aug 14, 2021
@Ousret Ousret deleted the patch-bc-classes-n-import branch August 14, 2021 20:29
@Ousret Ousret mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants