Skip to content

Stick footer for short posts #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2018
Merged

Stick footer for short posts #223

merged 1 commit into from
Apr 1, 2018

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Mar 30, 2018

Fix #222

minima-stick-footer

@DirtyF DirtyF requested a review from a team March 31, 2018 09:37
@ashmaroli
Copy link
Member

LGTM! 👍

@montyf
Copy link

montyf commented Mar 31, 2018 •
edited
Loading

Why not apply flex: 1; to .post-content as well?

Edit: Nevermind. I thought post-content corresponded to the post.html layout and page-content to page.html. However, I see that this isn't the case, and that only page-content needs the new attribute. I think the naming is a little confusing.

I just tried this solution and it worked for my blog! It's much simpler than the previous solution I had and doesn't require knowing the size of the footer beforehand.

@parkr
Copy link
Member

parkr commented Mar 31, 2018

Nice! I have never seen the flex properties. Are they cross-browser compatible?

@DirtyF
Copy link
Member Author

DirtyF commented Mar 31, 2018

@parkr https://caniuse.com/#feat=flexbox

@DirtyF DirtyF merged commit be3a0a1 into master Apr 1, 2018
@DirtyF DirtyF deleted the push-footer branch April 1, 2018 05:15
@jekyllbot jekyllbot mentioned this pull request Apr 10, 2018
Merged
@jekyll jekyll locked and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer should be at the bottom of the screen
5 participants
@DirtyF @ashmaroli @montyf @parkr @jekyllbot