Regression in lazygit behavior for gpg/ssh prompts with pinentry

[cavanaug]

Describe the bug
This is really a reopening of a previously fixed bug #3308 and pr #3478

To Reproduce
Steps to reproduce the behavior:

1. Configure your environment for using gpg as an ssh-agent
2. Reset the agent so it needs to prompt for the gpg password. "gpg-connect-agent reloadagent /bye"
3. Run lazygit, watch the screen go crazy

Screenshots
Same screen shots as in bug #3308

Version info:
Lazygit 0.42 - First fixed with PR#3478
Lazygit 0.44.1 - Still working
Lazygit 0.45.2 - Semi working, the initial prompt looks correct but upon return to the lazygit ui things are messed up
Lazygit 0.46+ - Completely messed up from first launch of lazygit

Additional context
It seems as though pinentry and lazygit are fighting over the screen and keyboard inputs. Like keystrokes are being sent to BOTH of them, as BOTH of them are attempting to draw on the screen simultaneously.

[stefanhaller]

You don't say which version you are using now. We had a regression like this briefly in 0.51.0, but it was fixed in 0.51.1 (see #4586). The current version is 0.52.

Please let me know if this explains it, or if the bug is still present in 0.52.

[cavanaug]

Same problem exists on 0.52

[stefanhaller]

Hm. I'm not familiar with gpg at all. Are you using a curses-based pinentry program? In that case I wouldn't be surprised that it doesn't work in lazygit.

Could you post a screenshot of how the gpg prompt looks for you when you do a git fetch on the command line, outside of lazygit?