nixcache: automatically configure nix daemon #1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before installing packages, check to see if the Nix daemon is already configured to use a Devbox cache when one is available. The user no longer needs to explicitly call `devbox cache configure`, however the command is still there (and hidden) to make sudo escalation possible. There are a few known limitations in this initial implementation: - We don't keep track of "no" responses to sudo, so Devbox will bug the user every time if they refuse. - The Nix daemon needs to restart after adding a trusted user. We currently only support auto-restarting the daemon on macOS and assume its managed with launchd. - We sleep rather than poll for the daemon to restart. This only happens when a trusted user is added, but it does make things a little flakier.
mikeland73
approved these changes
Apr 12, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before installing packages, check to see if the Nix daemon is already configured to use a Devbox cache when one is available. The user no longer needs to explicitly call
devbox cache configure, however the command is still there (and hidden) to make sudo escalation possible.There are a few known limitations in this initial implementation: