Refactor server setup and ignore type error #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until modelcontextprotocol/python-sdk#355 is solved, we should ignore type errors around AppContext.
Replaced `app_lifespan` with a standalone function and used `functools.partial` for injecting callback host and port dynamically. Consolidated logging setup into a shared `LOGGER` instance for consistency. Simplified and clarified the server initialization process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes the following changes:
Refactor server setup with
functools.partial:Replaced the
app_lifespanfunction to usefunctools.partialfor dynamically injecting the callback host and port. Logging was consolidated into a sharedLOGGERinstance for better consistency. The server initialization process was simplified and clarified for maintainability.Temporarily ignore type error related to
AppContext:Suppressed type errors surrounding
AppContextuntil modelcontextprotocol/python-sdk#355 is resolved.