Skip to content

Remove patch and use upstream SSEServerTransport #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025
Merged

Remove patch and use upstream SSEServerTransport #425

merged 4 commits into from
May 16, 2025

Conversation

jlowin
Copy link
Owner

@jlowin jlowin commented May 12, 2025

With modelcontextprotocol/python-sdk#659 merged, we can remove the patched transport and depend on the upstream again. This PR's tests will not pass until mcp 1.8.2 is released.

@Copilot Copilot AI review requested due to automatic review settings May 12, 2025 20:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the custom patched SSE server transport in favor of the upstream implementation from mcp and updates the dependency accordingly.

  • Removed the custom patched SSE server transport (src/fastmcp/low_level/sse_server_transport.py)
  • Updated the import in src/fastmcp/server/http.py to use the upstream transport
  • Bumped the mcp dependency version to 1.8.1 in pyproject.toml

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/fastmcp/server/http.py Updated to import the upstream SSEServerTransport
src/fastmcp/low_level/sse_server_transport.py Removed the custom patched transport implementation
pyproject.toml Updated mcp dependency version to ensure compatibility with the upstream transport

@JonZeolla
Copy link

JonZeolla commented May 16, 2025

FYI this (modelcontextprotocol/python-sdk@1cb7407) was released in v1.9.0

@jlowin
Copy link
Owner Author

jlowin commented May 16, 2025

Thank you @JonZeolla!

@jlowin jlowin merged commit 3e4577e into main May 16, 2025
6 of 7 checks passed
@jlowin jlowin deleted the sse-bugfix branch May 16, 2025 01:39
@jlowin jlowin added the bug Something isn't working label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants