docs: correct invalid default value in baseRef #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

joelanford merged 2 commits into joelanford:main from wtrocki:patch-2

Oct 9, 2023

Contributor

wtrocki commented Oct 5, 2023 •

edited

Loading

Base ref always need to be SHA. Using branch /refs as documented fails with errors.


          docs: correct invalid default

c21c005

Owner

joelanford commented Oct 9, 2023

Oh good catch! However, this is also not quite right. The default depends on the context of the run (PR vs merge queue is different). See https://github.com/joelanford/go-apidiff/pull/33/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R10


          Update README.md

3fde381

joelanford approved these changes

View reviewed changes

Owner

joelanford commented Oct 9, 2023

Thanks!

joelanford merged commit b7ad3b3 into joelanford:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet