fix: correct leading zeros and add building number patterns for DE_de
address provider 🐛
#2209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This PR improves the building number generation for German addresses. Previously, we generated multi-digit building numbers with leading 0s, which do not exist in Germany. This pr also adds more patterns to better cover German building numbers.
In detail:
010
. Single zeros can be valid building number (see here: https://www.uniserv.com/wissen/magazin/article/besonderheiten-von-zustelladressen/)14-16
, if property spans across multiple lots.MWE
before:
after:
What was wrong
Pattern was wrong.
How this fixes it
It fixes the pattern for German building numbers and adds more patterns to sample from.
Checklist
make lint