Remove sniffs in favor of build-in ones

[aik099]

The following sniffs can be removed in favor of one of core PHP_CodeSniffer sniffs, that do the same:

• ElseIfDeclarationSniff
• LowerCaseConstantSniff (removed in First round of changes needed for PHPCS-2 migration #101)
• CastSpacingSniff (removed in First round of changes needed for PHPCS-2 migration #101)
• SpaceAfterCastSniff (doesn't this conflict with above sniff?)
• ConcatenationSpacingSniff
• DisallowSpaceIndentSniff (removed in First round of changes needed for PHPCS-2 migration #101)
• SuperfluousWhitespaceSniff
• SemicolonSpacingSniff (removed in First round of changes needed for PHPCS-2 migration #101)

[photodude]

The following can also be eliminated since they are exact duplicates of the core PHP_CodeSniffer sniffs

• MemberVarSpacingSniff
• ObjectOperatorIndentSniff

[photodude]

On review, The Joomla ElseIfDeclarationSniff is different from the source and should not be removed
There is a small but important difference.

Joomla standard	Squiz standard
Usage of ELSE IF is not allowed; use ELSEIF instead	Usage of ELSEIF not allowed; use ELSE IF instead

[aik099]

On review, The Joomla ElseIfDeclarationSniff is different from the source and should not be removed
There is a small but important difference.

Are you sure, that there is no other elseif sniff in non-Squiz standard? I've found https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/PSR2/Sniffs/ControlStructures/ElseIfDeclarationSniff.php , but I needed to change it from warning to error in ruleset.xml to get desired result (https://github.com/aik099/CodingStandard/blob/master/CodingStandard/ruleset.xml#L188-L190).

[photodude]

@aik099 Thanks, I totally missed that elseif sniff in the PSR2 standard.

[photodude]

• On review of Squiz.Strings.ConcatenationSpacing there is a difference

Joomla standard	Squiz standard
Concat operator must be preceeded/followed by one space	Concat operator must not be surrounded by spaces

I was unable to find any other relevant ConcatenationSpacing sniffs in the other PHPCS standards.

• On review of Squiz.WhiteSpace.SuperfluousWhitespace I find the Joomla standard includes an additional registrar and methods for T_CLOSE_CURLY_BRACKET.
  I was unable to find any other relevant SuperfluousWhitespace sniffs in the other PHPCS standards.
• On review of Squiz.Formatting.SpaceAfterCast I find a few differences.
  Primarily I find the messages to be different.

Joomla standard	Squiz standard
Cast statements must be followed by a single space; expected "%s" but found "%s"	A cast statement must be followed by a single space

Following the annotated rule set guide there is a possibility that the Joomla standard could be replaced with the Squiz.Formatting.SpaceAfterCast rule and a custom message tag. <message></message>

There are some additional code differences, like the Joomla SpaceAfterCast standard passes the additional parameter $data to the addError () function, whereas the Squiz standard does not. I am unsure if this is a significant difference.

I am unsure if CastSpacing and SpaceAfterCast could/would result in a conflict.

[aik099]

I was unable to find any other relevant ConcatenationSpacing sniffs in the other PHPCS standards.

I can propose sniff of my own making: https://github.com/aik099/CodingStandard/blob/master/CodingStandard/Sniffs/Strings/ConcatenationSpacingSniff.php

On review of Squiz.WhiteSpace.SuperfluousWhitespace I find the Joomla standard includes an additional registrar and methods for T_CLOSE_CURLY_BRACKET.

Then just extend that sniff and add missing token. I thought that that sniff just removes trailing whitespaces, but then I don't understand why it needs any special tokens to operate with.

[photodude]

I have re-reviewed the Squiz.Strings.ConcatenationSpacing, I agree with this change since in PHPCS 2.3.x you can pass in a value for "spacing" and get the desired space before/after result from the ruleset.

I have re-reviewed Squiz.WhiteSpace.SuperfluousWhitespace, the Joomla sniff use of T_CLOSE_CURLY_BRACKET seems to be looking for a CURLY_BRACKET or semi-colon before the eolChar \n as a condition for the end of the file. Since this seems to be a duplication or confliction with the end of line sniff. As such I am in favor of replacing the custom sniff with Squiz.WhiteSpace.SuperfluousWhitespace.

On re-review of various included standards, rather than replacing with Squiz.Formatting.SpaceAfterCast; the correct replacement for the custom sniff would be Generic.Formatting.SpaceAfterCast

[photodude]

@mbabker This can be closed with the merge of #109

[mbabker]

Sounds good. Let's leave the 1.x structure in a "minimal maintenance" type of state.