Shorter sleep while waiting for encoder/decoder #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client is using the same jsoniter config with multiple goroutines it's very likely that few initial operations will encounter a placeholder encoder/decoder while the real one is being created by another goroutine. Having a full second sleep seems too conservative, since encoder/decoder will be created in a very short time. This is very easy to reproduce in any real environment with a few concurrent requests of the same type. A few initial requests will have 1s+ response time. Changing to 10ms should smooth out marshal/unmarshal times for these initial concurrent requests.
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
======================================
Coverage 84.5% 84.5%
======================================
Files 41 41
Lines 5195 5195
======================================
Hits 4390 4390
Misses 641 641
Partials 164 164
Continue to review full report at Codecov.
|
zhenzou
pushed a commit
to zhenzou/jsoniter
that referenced
this pull request
Feb 2, 2022
Shorter sleep while waiting for encoder/decoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client is using the same jsoniter config with multiple goroutines
it's very likely that few initial operations will encounter a placeholder
encoder/decoder while the real one is being created by another
goroutine. Having a full second sleep seems too conservative, since
encoder/decoder will be created in a very short time. This is very easy
to reproduce in any real environment with a few concurrent requests of
the same type. A few initial requests will have 1s+ response time.
Changing to 10ms should smooth out marshal/unmarshal times for these
initial concurrent requests.