Skip to content

More nil interface fixes #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2017

Conversation

toffaletti
Copy link
Contributor

This fixes a few more issues with encoding and decoding nil interfaces.

  1. encoding nil non-empty interfaces was failing
  2. encoding of nil json.Marshaler interfaces was failing
  3. decoding of interfaces where the JSON value was nil was failing

Unrelated: replaced usage of should.Equal(nil, err) with should.NoError(err) in tests.

@taowen taowen merged commit c463aa1 into json-iterator:master Sep 16, 2017
@codecov
Copy link

codecov bot commented Sep 16, 2017

Codecov Report

Merging #173 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   84.72%   84.78%   +0.05%     
==========================================
  Files          41       41              
  Lines        5199     5205       +6     
==========================================
+ Hits         4405     4413       +8     
+ Misses        633      627       -6     
- Partials      161      165       +4
Impacted Files Coverage Δ
feature_reflect_native.go 67.7% <100%> (+2.89%) ⬆️
feature_iter_skip.go 74.69% <0%> (-3.62%) ⬇️
feature_iter_object.go 67.12% <0%> (-3.43%) ⬇️
feature_iter_string.go 88.81% <0%> (-0.7%) ⬇️
feature_reflect.go 77.97% <0%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9277257...b5d2607. Read the comment docs.

zhenzou pushed a commit to zhenzou/jsoniter that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants