Skip to content

fix issue #389 #411 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

fix issue #389 #411 #432

merged 1 commit into from
Feb 6, 2020

Conversation

AllenX2018
Copy link
Collaborator

If the input json is integer/float, iter.Read() will meet EOF, which will make iter.Error not nil. But it's actually not an error.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #432 into master will decrease coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   86.85%   86.54%   -0.32%     
==========================================
  Files          41       41              
  Lines        5106     5106              
==========================================
- Hits         4435     4419      -16     
- Misses        535      551      +16     
  Partials      136      136
Impacted Files Coverage Δ
config.go 89.36% <100%> (ø) ⬆️
reflect_struct_decoder.go 81.89% <0%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfec88...3987001. Read the comment docs.

@AllenX2018 AllenX2018 merged commit 7acbb40 into json-iterator:master Feb 6, 2020
zhenzou pushed a commit to zhenzou/jsoniter that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant