Eslint does not work if the jsx key is missed inconditions

[malikiz]

Eslint does not work if the jsx key is missed in conditions

Screenshot:

Code:

const Test = (): React.ReactNode => {
  const list = [1, 2, 3, 4, 5];

  return (
    <div>
      {list.map(item => {
        if (item < 2) {
          /* The eslint error didn't work: */
          return <div>{item}</div>;
        }

        return <div />;
      })}
    </div>
  );
};

[ljharb]

If you add the key to the second div, do you get a warning on the first one? If not, there's definitely a bug.

[malikiz]

If you add the key to the second div, do you get a warning on the first one? If not, there's definitely a bug.

If I add a the key, the error/warning in the condition will not appear.

[TildaDares]

I'd like to work on this!

[ljharb]

Go for it!

[TildaDares]

@ljharb Just to clarify, is the warning supposed to be displayed on both divs?

[ljharb]

Correct.