Skip to content

[New] jsx-props-no-multi-spaces: Add automatic fix for no line gap between props #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

justisb
Copy link
Contributor

@justisb justisb commented Jun 2, 2025

Extends automatic fix support to cover the "no line gap" half of the jsx-props-no-multi-spaces rule. There is already automatic fix support for the "only one space" enforcement.

Initially tagging as a [Fix] because it was unexpected that the rule does not fix line gaps when the rule is stated to be automatically fixable in the docs.

@justisb justisb force-pushed the fix-jsx-props-no-multi-spaces branch from ec5d4e6 to b660143 Compare June 3, 2025 18:30
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

It's still a [New], though, because one should never assume every error is autofixable :-)

@ljharb
Copy link
Member

ljharb commented Jun 3, 2025

@justisb ah - because you made this PR from a repo you don't own, i can't rebase it properly (you should only be making PRs from a fork under your own username).

To fix it, can you add me to https://github.com/Popmenu/eslint-plugin-react temporarily? You're free to remove me after the PR is updated.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (dd2e968) to head (b660143).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3929      +/-   ##
==========================================
- Coverage   97.73%   97.52%   -0.22%     
==========================================
  Files         136      133       -3     
  Lines        9997     9996       -1     
  Branches     3715     3717       +2     
==========================================
- Hits         9771     9749      -22     
- Misses        226      247      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justisb justisb changed the title [Fix] jsx-props-no-multi-spaces: Add automatic fix for no line gap between props [New] jsx-props-no-multi-spaces: Add automatic fix for no line gap between props Jun 3, 2025
@justisb
Copy link
Contributor Author

justisb commented Jun 3, 2025

Thanks @ljharb. I just reopened as #3930 with edits from maintainers enabled.

@justisb justisb closed this Jun 3, 2025
@ljharb
Copy link
Member

ljharb commented Jun 3, 2025

oof, that leaves this PR as an eternally undeleteable ref on the repo :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants