Skip to content

chore: move prettier and eslint configuration under package.json #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2023
Merged

chore: move prettier and eslint configuration under package.json #188

merged 3 commits into from
Apr 3, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

Changes proposed by this PR can be summarised as follows :-

  • Move the content from .prettierrc under the prettier key in package.json. Source(prettier docs)
  • Move the content from .eslintrc.js under the eslintConfig key in package.json. Source(eslint docs)
  • Move the content from .eslintignore under the eslintIgnore key in package.json. Source(eslint docs)

Doing so, would lead to a more minimal project structure without any functional change. This PR mirrors the change from (jupyter-server/jupyter_server#1246)

@welcome
Copy link

welcome bot commented Mar 27, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@SauravMaheshkar
Copy link
Contributor Author

@blink1073 Request for Review (sorry for the ping)

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit b2e44fb into jupyter-server:main Apr 3, 2023
@welcome
Copy link

welcome bot commented Apr 3, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jtpio
Copy link
Member

jtpio commented Apr 4, 2023

Thanks @SauravMaheshkar!

Wondering if we should do the same in the extension cookiecutter as well? I opened jupyterlab/extension-cookiecutter-ts#302 to consider this.

@SauravMaheshkar
Copy link
Contributor Author

Ofcouse @jtpio thanks for the ping. On it !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants