Simplifying the OpenAI provider to use multiple model providers #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dlqqq
reviewed
Feb 26, 2025
| @@ -125,19 +128,24 @@ export function ChatSettings(props: ChatSettingsProps): JSX.Element { | |||
| } | |||
|
|
|||
| setLmLocalId(server.chat.lmLocalId); | |||
| setEmLocalId(server.config.embeddings_provider_id ?? ''); | |||
There was a problem hiding this comment.
I think this is the line causing the local model ID being set to the universal model ID (including provider prefix). We need to add emLocalId to the server.chat: ProvidersInfo object. This is returned from use-server-info.ts.
dlqqq
reviewed
Feb 26, 2025
| const [clmProvider, setClmProvider] = | ||
| useState<AiService.ListProvidersEntry | null>(null); | ||
| const [showLmLocalId, setShowLmLocalId] = useState<boolean>(false); | ||
| const [showEmLocalId, setShowEmLocalId] = useState<boolean>(false); |
There was a problem hiding this comment.
This looks like a duplicate of line 60.
|
Replaced by PR #1264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OpenAI model interface has been widely adopted by many model providers (DeepSeek, vLLM, etc.) and this PR enables accessing these models using the OpenAI provider. Current OpenAI models are also accessible via the same interface.
This PR also updates related documentation on the use of these models that work via the OpenAI provider.
Demo
See the new usage of models and the required settings shown below, note the new "OpenAI::general interface":
For any OpenAI model:
For DeepSeek models:
For models deployed with vLLM:
Embedding Models
First, tested to make sure that the OpenAI models are working as intended with no changes to the code:
Second, modified check that the interface takes any OpenAI embedding model as an input and test that it works with OpenAI models as before:
Code Completion
This is also supported now as follows:
