-
Notifications
You must be signed in to change notification settings - Fork 31
K8s 1.33 #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s 1.33 #287
Conversation
Could you help add some unit test suites for the k8s package? Thank you! |
Sure, i'll open a PR to add tests for k8s package and let's continue with this PR after merging the tested PRS. |
seems like generater have some problem:
ref: https://cloud-native.slack.com/archives/C05TC96NWN8/p1745517886457219 and i have reproduced it in this PR. |
@Peefy rebased main, CI is green: https://github.com/kcl-lang/modules/actions/runs/15073123074/job/42374177628?pr=287 , ready to merge |
opps, Obviously I forgot that the 1.33 package needs to be regenerated based on #288 (comment) |
97b438e
to
1bf1d32
Compare
Signed-off-by: Lan <[email protected]>
https://github.com/kcl-lang/modules/actions/runs/15187072541/job/42709970864?pr=287 ...
--- PASS: TestK8sPackages/1.33_deplyoment (0.12s)
--- PASS: TestK8sPackages/1.33_ingress (0.10s) @Peefy ready to go :) finally |
@@ -65,6 +65,9 @@ jobs: | |||
run: | | |||
if echo "${{ steps.changed-files.outputs.all_changed_files }}" | grep -q 'kcl.mod'; then | |||
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do | |||
if [[ "$file" == *.go ]]; then | |||
continue | |||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix https://github.com/kcl-lang/modules/actions/runs/14854063178/job/41703108401
...
go: cannot run *_test.go files (main_test.go)
Amazing Job! LGTM! |
NOTE: deleted
scripts/k8s/processed-swagger.json
andscripts/k8s/swagger.json
, i think it's not need here, remind me if i missed something.1. Please confirm that you have read the document before PR submitted
2. Contact Information(Optional)
If it is convenient, please provide your contact information so we can reach you when processing the PR: