Skip to content

update golangci-lint to 2.1.6 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

update golangci-lint to 2.1.6 #64

merged 3 commits into from
May 22, 2025

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 21, 2025

Summary

One of the less painful golangci-lint 2 migrations I have seen and done in the last few weeks.

What Type of PR Is This?

/kind chore

Release Notes

NONE

@xrstf xrstf requested a review from embik May 21, 2025 15:41
@kcp-ci-bot
Copy link
Contributor

@xrstf: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

Summary

One of the less painful golangci-lint 2 migrations I have seen and done in the last few weeks.

What Type of PR Is This?

/kind chore

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2025
@xrstf
Copy link
Contributor Author

xrstf commented May 21, 2025

/kind cleanup

@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 21, 2025
embik
embik approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2025
@embik
Copy link
Member

embik commented May 22, 2025

/lgtm cancel

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@kcp-ci-bot kcp-ci-bot requested a review from embik May 22, 2025 08:15
xmudrii
xmudrii approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f6fbe04c97457d801117853dfdf6ddf0878703f

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot merged commit 2a63885 into main May 22, 2025
9 checks passed
@kcp-ci-bot kcp-ci-bot deleted the bump-linter branch May 22, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@embik embik Awaiting requested review from embik

Assignees

@embik embik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xrstf @kcp-ci-bot @embik @xmudrii