Introduce NetPnL in Position and Trades.

[abhirathmahipal]

It's a good idea to maintain pl and net_pl separately. Reasons being

• commission is directly deducted from cash once a trade is entered.
• Clients can use pl and net_pl as per their use case.

If you're on the same page, will make similar changes for pl_pct.

[kernc]

Actually I'm not on the same page. I prefer smaller and well-documented APIs as I believe they are easier to work with, and, importantly, smaller API surfaces requires less maintaining.

If the user is made aware that PnL stats account for (or ignore) Commissions, they can simply do the remaining desired arithmetic themselves. As opposed to never being sure what attribute/accessor to call in a deluge of those ...

[abhirathmahipal]

I was thinking along your lines earlier.

Reasoning for the above approach

• Trade._commission is set only after the Trade is closed. If the Strategy were use Trade.pl, it wouldn't reflect the commission.

Have raised a new pull request based on your inputs.