feat(workshop): Simplify resource crafting #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversalzburg
added
type:feature
oliversalzburg
force-pushed
the
feat/workshop
branch
3 times, most recently
from
18bdd66 to
71377f0
Compare
oliversalzburg
force-pushed
the
main
branch
2 times, most recently
from
91dfd47 to
6c11005
Compare
There was some edge case handling to balance production between plates and steel, which seems entirely redundant, given the balancing behavior of limited crafting. The trigger applied to some hardcoded material, only a single one, and only for some crafts. This could cause unintuitive crafting behavior. Even if the trigger wasn't hit, a resource could still be crafted under certain conditions. The behavior of limited crafting was inconsistent. The way resource crafting behaves now, should be far more intuitive and consistent. Additionally, it has now been documented.
oliversalzburg
force-pushed
the
feat/workshop
branch
from
71377f0 to
8b48268
Compare
oliversalzburg
added
status:completed
oliversalzburg
modified the milestones:
v2.0-rc,
v2.0-beta.9,
v2.0.0-beta.9,
v2.0.0-beta.8
oliversalzburg
removed
the
prio:accepted
github-actions
bot
added
needs:triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some edge case handling to balance production between plates and steel, which seems entirely redundant, given the balancing behavior of limited crafting.
The trigger applied to some hardcoded material, only a single one, and only for some crafts. This could cause unintuitive crafting behavior.
Even if the trigger wasn't hit, a resource could still be crafted under certain conditions.
The behavior of limited crafting was inconsistent.
The way resource crafting behaves now, should be far more intuitive and consistent. Additionally, it has now been documented.