Implement entire KG API Surface and resolve Regressions #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversalzburg
added
type:bug
oliversalzburg
force-pushed
the
fix/upgrade-regressions
branch
from
92f0c97 to
b899bca
Compare
oliversalzburg
force-pushed
the
fix/upgrade-regressions
branch
18 times, most recently
from
6923c16 to
61651ee
Compare
oliversalzburg
force-pushed
the
fix/upgrade-regressions
branch
7 times, most recently
from
cc817b9 to
28640d4
Compare
…cating build buttons as it does not contain html and the values are the same
…tml now and ids are stable
…to UpgradeManager name field
oliversalzburg
force-pushed
the
fix/upgrade-regressions
branch
3 times, most recently
from
3734917 to
0af5f5d
Compare
oliversalzburg
force-pushed
the
fix/upgrade-regressions
branch
from
0af5f5d to
af4946b
Compare
oliversalzburg
added
needs:testing
github-actions
bot
added
needs:triage
oliversalzburg
removed
prio:important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The game has received substantial updates recently, causing several regressions in KS.
Resolving these regressions brought focus to a long-standing tech dept since the first port of KS 2.0: the TypeScript types. In the initial port, we only authored types for what we used in KS. Some of the approaches in KS are outdated and problematic, which is what caused the recent regressions. To allow us to resolve these issues and innovate, the game types need to better reflect the game as-is.
Thus, I'm aiming to provide a typed surface for the entire game API, and then use that to provide a robust solution for the current issues.
Fixes #947
Contributes to #76, #77, #78
Closes #950