Skip to content

chore: timeline clarify remaining time #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

chore: timeline clarify remaining time #2009

merged 1 commit into from
May 26, 2025
+2 −3

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented May 26, 2025 •
edited by coderabbitai bot
Loading

PR-Codex overview

This PR focuses on improving the wording in the Timeline.tsx file for better clarity regarding funding options for losing and winning cases.

Detailed summary

  • Changed the text for the countdown of losing options from "left until losing options can be funded" to "remaining to fund losing options".
  • Changed the text for the countdown of winning options from "left until winning option can be funded" to "remaining to fund winning option".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Updated countdown messages in the AppealBanner for improved clarity and consistency. The banner now uses "remaining to fund" phrasing in countdown messages.

@kemuru kemuru requested a review from a team as a code owner May 26, 2025 12:46
@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for kleros-v2-testnet ready!

Name Link
🔨 Latest commit ad47783
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-testnet/deploys/683462a98157740008698fe7
😎 Deploy Preview https://deploy-preview-2009--kleros-v2-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 26, 2025 •
edited
Loading

Walkthrough

The change updates the wording of countdown messages in the AppealBanner component within the case details timeline. The logic and control flow remain unchanged, but the displayed strings for countdowns now consistently use the phrase "remaining to fund" for both loser and winner side countdowns.

Changes

File Change Summary
web/src/pages/Cases/CaseDetails/Timeline.tsx Updated countdown message text in AppealBanner; logic unchanged.

Poem

A tweak in the words, a gentle nudge,
"Remaining to fund"—no more to judge!
The timeline now sings with clearer intent,
As cases march onward, their messages sent.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ca9066 and ad47783.

📒 Files selected for processing (1)
  • web/src/pages/Cases/CaseDetails/Timeline.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: Redirect rules - kleros-v2-neo
  • GitHub Check: Header rules - kleros-v2-neo
  • GitHub Check: Pages changed - kleros-v2-neo
  • GitHub Check: Redirect rules - kleros-v2-university
  • GitHub Check: Header rules - kleros-v2-university
  • GitHub Check: Pages changed - kleros-v2-university
  • GitHub Check: SonarCloud
  • GitHub Check: contracts-testing
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Redirect rules - kleros-v2-testnet
  • GitHub Check: Redirect rules - kleros-v2-testnet
  • GitHub Check: Header rules - kleros-v2-testnet
  • GitHub Check: Header rules - kleros-v2-testnet
  • GitHub Check: Pages changed - kleros-v2-testnet
  • GitHub Check: Pages changed - kleros-v2-testnet
🔇 Additional comments (1)
web/src/pages/Cases/CaseDetails/Timeline.tsx (1)

86-86: LGTM! Text clarification improves user experience.

The updated countdown messages now use consistent and clearer wording with "remaining to fund" phrasing. This aligns well with the PR objective of clarifying remaining time and provides more actionable messaging for users.

The conditional logic remains sound and the pluralization is appropriately maintained ("losing options" vs "winning option").

Also applies to: 89-89

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →

Name Link
🔨 Latest commit ad47783
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-university/deploys/683462a919d20700084ea9e4

@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for kleros-v2-neo ready!

Name Link
🔨 Latest commit ad47783
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-neo/deploys/683462a9c79ac800087989eb
😎 Deploy Preview https://deploy-preview-2009--kleros-v2-neo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 26, 2025

Code Climate has analyzed commit ad47783 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

Name Link
🔨 Latest commit ad47783
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-testnet-devtools/deploys/683462a9c8befb00087cc92a
😎 Deploy Preview https://deploy-preview-2009--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

alcercu
alcercu approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 349783f into dev May 26, 2025
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemuru @alcercu