Skip to content

add scripts to change kmesh version automatically #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

add scripts to change kmesh version automatically #1183

merged 2 commits into from
Jan 15, 2025

Conversation

LiZhenCheng9527
Copy link
Contributor

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
Added script that automatically updates kmesh VERSION based on github tags.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.24%. Comparing base (e5c49be) to head (172252f).
Report is 32 commits behind head on main.

see 17 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08a108...172252f. Read the comment docs.

hzxuzhonghu
hzxuzhonghu reviewed Jan 14, 2025
View reviewed changes
.github/workflows/release-master.yaml Outdated
- name: change kmesh version
env:
VERSION: ${{ github.ref_name }}
run: make update-version UPDATE_VERSION=${{ github.ref_name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a pr merged to main branch, it will get the version=main?

@LiZhenCheng9527
Copy link
Contributor Author

/hold

@LiZhenCheng9527 LiZhenCheng9527 force-pushed the version-change-scritp branch 2 times, most recently from 221a425 to c9e3098 Compare January 14, 2025 11:53
@kmesh-bot kmesh-bot added size/L and removed size/M labels Jan 14, 2025
@LiZhenCheng9527
Copy link
Contributor Author

/cancel hold

hzxuzhonghu
hzxuzhonghu approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Jan 15, 2025
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 0c23ba5 into kmesh-net:main Jan 15, 2025
12 checks passed
@kmesh-bot
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #1184

@kmesh-bot kmesh-bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved cherrypick/release-1.0 kind/enhancement New feature or request lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiZhenCheng9527 @kmesh-bot @hzxuzhonghu