-
Notifications
You must be signed in to change notification settings - Fork 109
feat(authz): Add E2E test for kmeshctl authz functionality #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ravjot07
wants to merge
2
commits into
kmesh-net:main
Choose a base branch
from
ravjot07:e2e-authz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
/* | ||
* Copyright The Kmesh Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package kmeshctl_test | ||
|
||
import ( | ||
"fmt" | ||
"strings" | ||
"testing" | ||
"time" | ||
|
||
"istio.io/istio/pkg/test/shell" | ||
) | ||
|
||
// TestKmeshctlAuthz verifies the kmeshctl authz (enable/disable/status) against a Kmesh Daemon pod. | ||
func TestKmeshctlAuthz(t *testing.T) { | ||
// 1) Grab the first Kmesh daemon pod from the cluster: | ||
podName, err := getFirstKmeshPod() | ||
if err != nil { | ||
t.Fatalf("could not retrieve a kmesh daemon pod name: %v", err) | ||
} | ||
t.Logf("Using Kmesh daemon pod: %s", podName) | ||
|
||
// 2) Enable Authz on the Kmesh Daemon Pod | ||
t.Run("enable-authz", func(t *testing.T) { | ||
cmd := fmt.Sprintf("kmeshctl authz enable %s", podName) | ||
out, err := shell.Execute(true, cmd) | ||
if err != nil { | ||
t.Fatalf("failed to enable authz on pod %q: %v\noutput: %s", podName, err, out) | ||
} | ||
t.Logf("enable-authz output:\n%s", out) | ||
}) | ||
|
||
// 3) Check that Authz is enabled | ||
t.Run("verify-authz-enabled", func(t *testing.T) { | ||
// Wait a moment for Kmesh Daemon to process. | ||
time.Sleep(2 * time.Second) | ||
|
||
cmd := fmt.Sprintf("kmeshctl authz status %s", podName) | ||
out, err := shell.Execute(true, cmd) | ||
if err != nil { | ||
t.Fatalf("failed to check authz status: %v\noutput: %s", err, out) | ||
} | ||
t.Logf("status output:\n%s", out) | ||
|
||
// We assume the status output includes "true" or "enabled" if authz is on. | ||
if !strings.Contains(out, "true") && !strings.Contains(strings.ToLower(out), "enabled") { | ||
t.Fatalf("expected authz to be enabled, got: %s", out) | ||
} | ||
}) | ||
|
||
// 4) Disable Authz on the Kmesh Daemon Pod | ||
t.Run("disable-authz", func(t *testing.T) { | ||
cmd := fmt.Sprintf("kmeshctl authz disable %s", podName) | ||
out, err := shell.Execute(true, cmd) | ||
if err != nil { | ||
t.Fatalf("failed to disable authz on pod %q: %v\noutput: %s", podName, err, out) | ||
} | ||
t.Logf("disable-authz output:\n%s", out) | ||
}) | ||
|
||
// 5) Check that Authz is disabled | ||
t.Run("verify-authz-disabled", func(t *testing.T) { | ||
// Wait a moment for Kmesh Daemon to process. | ||
time.Sleep(2 * time.Second) | ||
|
||
cmd := fmt.Sprintf("kmeshctl authz status %s", podName) | ||
out, err := shell.Execute(true, cmd) | ||
if err != nil { | ||
t.Fatalf("failed to check authz status: %v\noutput: %s", err, out) | ||
} | ||
t.Logf("status output:\n%s", out) | ||
|
||
// We assume the status output includes "false" or "disabled" if authz is off. | ||
if !strings.Contains(out, "false") && !strings.Contains(strings.ToLower(out), "disabled") { | ||
t.Fatalf("expected authz to be disabled, got: %s", out) | ||
} | ||
}) | ||
} | ||
|
||
// getFirstKmeshPod uses kubectl to find the first Kmesh Daemon pod (label app=kmesh) in kmesh-system. | ||
func getFirstKmeshPod() (string, error) { | ||
cmd := `kubectl get pods -n kmesh-system -l app=kmesh -o jsonpath='{.items[0].metadata.name}'` | ||
out, err := shell.Execute(true, cmd) | ||
if err != nil { | ||
return "", fmt.Errorf("error retrieving kmesh daemon pod name: %v", err) | ||
} | ||
trimmed := strings.TrimSpace(out) | ||
if trimmed == "" { | ||
return "", fmt.Errorf("no Kmesh daemon pod found in kmesh-system namespace") | ||
} | ||
return trimmed, nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should install
kmeshctl
in e2e cluster first, refer to what I have done in another PR:test/e2e/run_test.sh
of https://github.com/kmesh-net/kmesh/pull/641/filesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okiee @YaoZengzeng i will take a look into this file and update this... really appreciate your guidance