Skip to content

fix possible e2e panic and update maxportnum warning #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

Kuromesi
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
/kind bug
Fix possible e2e panic and add service name in warning of service exceeded max port

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Mar 20, 2025
@kmesh-bot kmesh-bot requested review from nlgwcy and YaoZengzeng March 20, 2025 09:18
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.47%. Comparing base (d6ca5c8) to head (7a44775).
Report is 24 commits behind head on main.

Files with missing lines Coverage Δ
pkg/controller/workload/workload_processor.go 61.92% <100.00%> (+0.52%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a450591...7a44775. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hzxuzhonghu
hzxuzhonghu previously approved these changes Mar 24, 2025
@LiZhenCheng9527
Copy link
Contributor

Please sign your commit.

Co-authored-by: Yao Zengzeng <[email protected]>
Signed-off-by: Kuromesi <[email protected]>
@LiZhenCheng9527
Copy link
Contributor

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit e6c32f4 into kmesh-net:main Mar 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants