Skip to content

add e2e tests for isito 1.25 and remove e2e tests for isito 1.22 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

YaoZengzeng
Copy link
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1292

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.62%. Comparing base (d762031) to head (2d58877).
Report is 3 commits behind head on main.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cba483...2d58877. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YaoZengzeng
Copy link
Member Author

/retest

@YaoZengzeng
Copy link
Member Author

All IPv6 tests failed, because of the kernel issue: actions/runner-images#11985 which will cause kubeproxy fail to run:

root@dev:~/scripts# klp kube-proxy-b95rc   -n kube-system 
I0410 11:41:11.086641       1 server.go:1062] "Successfully retrieved node IP(s)" IPs=["fc00:f853:ccd:e793::3"]
I0410 11:41:11.086857       1 conntrack.go:119] "Set sysctl" entry="net/netfilter/nf_conntrack_tcp_timeout_established" value=86400
I0410 11:41:11.086942       1 conntrack.go:119] "Set sysctl" entry="net/netfilter/nf_conntrack_tcp_timeout_close_wait" value=3600
I0410 11:41:11.163385       1 server.go:659] "kube-proxy running in dual-stack mode" primary ipFamily="IPv6"
I0410 11:41:11.163461       1 server_linux.go:165] "Using iptables Proxier"
I0410 11:41:11.167114       1 server_linux.go:511] "Detect-local-mode set to ClusterCIDR, but no cluster CIDR for family" ipFamily="IPv4"
I0410 11:41:11.167147       1 server_linux.go:528] "Defaulting to no-op detect-local"
I0410 11:41:11.170779       1 proxier.go:243] "Setting route_localnet=1 to allow node-ports on localhost; to change this either disable iptables.localhostNodePorts (--iptables-localhost-nodeports) or set nodePortAddresses (--nodeport-addresses) to filter loopback addresses"
I0410 11:41:11.171100       1 server.go:872] "Version info" version="v1.30.0"
I0410 11:41:11.171139       1 server.go:874] "Golang settings" GOGC="" GOMAXPROCS="" GOTRACEBACK=""
I0410 11:41:11.174884       1 config.go:192] "Starting service config controller"
I0410 11:41:11.175728       1 config.go:101] "Starting endpoint slice config controller"
I0410 11:41:11.176193       1 shared_informer.go:313] Waiting for caches to sync for service config
I0410 11:41:11.175736       1 config.go:319] "Starting node config controller"
I0410 11:41:11.176250       1 shared_informer.go:313] Waiting for caches to sync for endpoint slice config
I0410 11:41:11.176495       1 shared_informer.go:313] Waiting for caches to sync for node config
I0410 11:41:11.277195       1 shared_informer.go:320] Caches are synced for endpoint slice config
I0410 11:41:11.277291       1 shared_informer.go:320] Caches are synced for service config
I0410 11:41:11.277510       1 shared_informer.go:320] Caches are synced for node config
E0410 11:41:11.500986       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 23
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >
I0410 11:41:11.501022       1 proxier.go:810] "Sync failed" retryingTime="30s"
E0410 11:41:31.012148       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 22
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >
I0410 11:41:31.012172       1 proxier.go:810] "Sync failed" retryingTime="30s"
E0410 11:41:39.126737       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 22
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >
I0410 11:41:39.126766       1 proxier.go:810] "Sync failed" retryingTime="30s"
E0410 11:42:09.214364       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 22
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >
I0410 11:42:09.214392       1 proxier.go:810] "Sync failed" retryingTime="30s"
E0410 11:42:39.310901       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 22
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >
I0410 11:42:39.310942       1 proxier.go:810] "Sync failed" retryingTime="30s"
E0410 11:43:09.393419       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 22
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >
I0410 11:43:09.393446       1 proxier.go:810] "Sync failed" retryingTime="30s"
E0410 11:43:39.486782       1 proxier.go:1511] "Failed to execute iptables-restore" err=<
        exit status 2: Warning: Extension MARK revision 0 not supported, missing kernel module?
        ip6tables-restore v1.8.9 (nf_tables): unknown option "--xor-mark"
        Error occurred at line: 22
        Try `ip6tables-restore -h' or 'ip6tables-restore --help' for more information.
 >

@YaoZengzeng
Copy link
Member Author

/retest

@hzxuzhonghu
Copy link
Member

We may need to skip ipv6 temporarily until github runner is fixed

@YaoZengzeng
Copy link
Member Author

/retest

@YaoZengzeng
Copy link
Member Author

/retest

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 546b11e into kmesh-net:main Apr 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support istio 1.25
3 participants