Skip to content

rfac: added gomft in makefile #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

rfac: added gomft in makefile #1324

merged 1 commit into from
Apr 22, 2025

Conversation

yp969803
Copy link
Contributor

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
added gomft in makefile

Which issue(s) this PR fixes:
Fixes #1323

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Apr 22, 2025
hzxuzhonghu
hzxuzhonghu reviewed Apr 22, 2025
View reviewed changes
Makefile Outdated
@@ -208,7 +208,8 @@ e2e-ipv6:

.PHONY: format
format:
./hack/format.sh
-./hack/format.sh
gofmt -s -w .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move it into format.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (b1ea0b3) to head (6cdabb0).
Report is 5 commits behind head on main.

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f216fd3...6cdabb0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yp969803
rfac: added gomft in makefile
6cdabb0 
Signed-off-by: Yash Patel <[email protected]>

chore: moved gofmt to format.sh

Signed-off-by: Yash Patel <[email protected]>
@yp969803
Copy link
Contributor Author

@hzxuzhonghu done the changes

@yp969803
Copy link
Contributor Author

/retest

hzxuzhonghu
hzxuzhonghu reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Apr 22, 2025
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 355c955 into kmesh-net:main Apr 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved kind/enhancement New feature or request lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gofmt in make format in Makefile
3 participants
@yp969803 @kmesh-bot @hzxuzhonghu