-
Notifications
You must be signed in to change notification settings - Fork 110
Fix cgroup_skb/* get sk_storage failed #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -260,6 +260,23 @@ static inline void remove_kmesh_managed_ip(__u32 family, __u32 ip4, __u32 *ip6) | |||
BPF_LOG(ERR, KMESH, "remove ip failed, err is %d\n", err); | |||
} | |||
|
|||
static inline bool sock_conn_from_sim(struct __sk_buff *skb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, kmesh simulate 0.0.0.2:930 or 0.0.0.2:931 when it need to manage the pod
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
have u checked it locally, using bpf logs, it is better if we check the stuffs locally before merging to prevent bugs.
|
what do you mean? /retest |
i was just asking if u have checked it locally, does the normal packets reaching to the observed_data function |
I am not sure if kmesh restart would influence the long connection metric. For this patch, it does not bring regression for long connection |
bpf/include/bpf_common.h
Outdated
__u16 enable_port = ENABLE_KMESH_PORT; | ||
__u16 disable_port = DISABLE_KMESH_PORT; | ||
__u16 dst_port = (__u16)(skb->remote_port >> 16); | ||
if (bpf_ntohs(dst_port) != enable_port && bpf_ntohs(dst_port) != disable_port) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (bpf_ntohs(dst_port) != enable_port && bpf_ntohs(dst_port) != disable_port) | |
if (bpf_ntohs(dst_port) != ENABLE_KMESH_PORT && bpf_ntohs(dst_port) != DISABLE_KMESH_PORT) |
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
/retest |
@nlgwcy Another look |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1348
Special notes for your reviewer:
Does this PR introduce a user-facing change?: