-
Notifications
You must be signed in to change notification settings - Fork 109
added periodic report knob for long connection #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a feature to control periodic reporting for long connections by adding a new knob that propagates the setting from the status server, through the BPF loader, into the kernel-space BPF programs.
- Adds a new handler in pkg/status/status_server.go to update the periodic report setting.
- Implements the UpdateEnablePeriodicReport method in pkg/bpf/bpf.go to change the knob value.
- Updates BPF C code and related Go mapping structs to include the new periodic report variable.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
File | Description |
---|---|
pkg/status/status_server.go | Adds code to update the periodic report knob based on the enabled flag. |
pkg/bpf/bpf.go | Introduces UpdateEnablePeriodicReport function to propagate the knob value. |
bpf/kmesh/workload/cgroup_skb.c | Adds a global variable and inline function to check the periodic report setting. |
bpf/kmesh/bpf2go/* | Updates BPF mapping specifications to include the new periodic report variable. |
Comments suppressed due to low confidence (2)
pkg/bpf/bpf.go:515
- [nitpick] Consider renaming the parameter 'EnablePeriodicReport' to 'enablePeriodicReport' to follow Go naming conventions.
func (l *BpfLoader) UpdateEnablePeriodicReport(EnablePeriodicReport uint32) error {
bpf/kmesh/workload/cgroup_skb.c:16
- [nitpick] The function name 'is__periodic_report_enable' contains a double underscore; renaming it to 'is_periodic_report_enabled' could improve clarity and consistency.
static inline bool is__periodic_report_enable()
@hzxuzhonghu @nlgwcy @LiZhenCheng9527 review request !! |
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
added periodic report knob for long connection
Which issue(s) this PR fixes:
Fixes #1356
Special notes for your reviewer:
Does this PR introduce a user-facing change?: