fix log cannot print in kernel 5.10 by bpf_trace_printk

[lec-bit]

bpf_trace_printk cannot print two %s, need to fix

What type of PR is this?
/kind bug

What this PR does / why we need it:
bpf_trace_printk cannot print two %s, need to fix

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.26%. Comparing base (44d5b2b) to head (e4ee237).
Report is 158 commits behind head on main.

see 23 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc5794...e4ee237. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hzxuzhonghu]

@nlgwcy can you please give some suggestion

[nlgwcy]

Suggested change

	BPF_LOG(INFO, CLUSTER, "cluster=\"%s\"\n", name);
	BPF_LOG(INFO, CLUSTER, "cluster=\"%s\",", name);

[lec-bit]

BPF logs are printed on a new line each time in bpf_trace_printk. Adding \n here will not affect whether the log is continuous.

[nlgwcy]

@nlgwcy can you please give some suggestion

The restriction is fixed in this PR: torvalds/linux@d9c9e4db186ab

[hzxuzhonghu]

Ok, so in 5.10 kernel we must fix it. Is this the right way?

[hzxuzhonghu]

Can you also fix bpf/kmesh/workload/xdp.c

[hzxuzhonghu]

Seems xdp_deny_packet is not used anymore

[lec-bit]

Can you also fix bpf/kmesh/workload/xdp.c

I don't know if this place can be repaired simply by taking it apart.
`

        BPF_LOG(
        INFO,
        XDP,
        "auth denied, src ip: %s, dst ip %s, dst port: %u\n",
        ip2str(&tuple_info->ipv4.saddr, true),
        ip2str(&tuple_info->ipv4.daddr, true),
        bpf_ntohs(tuple_info->ipv4.dport)); 

`

    BPF_LOG(INFO, XDP, "auth denied, src ip: %s",ip2str(&tuple_info->ipv4.saddr, true), false))
    BPF_LOG(
        INFO,
        XDP,
        "auth denied, dst ip %s, dst port: %u\n",
        ip2str(&tuple_info->ipv4.daddr, true),
        bpf_ntohs(tuple_info->ipv4.dport));`

[hzxuzhonghu]

I think this function can be removed now

[lec-bit]

I think this function can be removed now

ok
I see that there is only empty definition and no usage.

[lec-bit]

/retest

[LiZhenCheng9527]

/lgtm
/approve

[kmesh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LiZhenCheng9527]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment