fix kmeshctl version report error #1371
Conversation
Signed-off-by: LiZhenCheng9527 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ctl/version/version.go
Outdated
|
|
||
| // match release version vx.y.z-(alpha) | ||
| func stringMatch(str string) bool { | ||
| pattern := `^v\d+\.\d+\.\d+(-[a-zA-Z0-9]+)?$` |
There was a problem hiding this comment.
Does it support matching v1.1.1-alpha.0?
There was a problem hiding this comment.
No. Add a unit test to validata it.
There was a problem hiding this comment.
https://semver.org/ FYI, i think we should support it
There was a problem hiding this comment.
The regular expression was modified to handle this case.
Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created: #1386 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1364
Special notes for your reviewer:
Does this PR introduce a user-facing change?: